[digikam] [Bug 318357] New: regexp based image grouping

classic Classic list List threaded Threaded
27 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] New: regexp based image grouping

Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

            Bug ID: 318357
           Summary: regexp based image grouping
    Classification: Unclassified
           Product: digikam
           Version: 3.1.0
          Platform: Other
                OS: All
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Albums GUI
          Assignee: [hidden email]
          Reporter: [hidden email]

Hi.

It seems that one can already group images together in digikam, but this
happens only manually (e.g. selecting them and then tell it to group them).

What I'd like to see is regular expression (ideally PCRE) based grouping rules.
Perhaps even on a per folder basis (maybe with subfolders inheriting the rules
from parent folders, if none are explicitly set or cleared).

WIth that one could easily do things like:
a) Group images:
foo\..+

b) a) Group images:
foo\.raw
foo\.jpeg
foo\.jpg
but no others

c) Group images:
foo\..+
but not
foo\.png

d) mightier things like, group
foo(-.+|).*
which I'd find handy cause I use about the following system:
The base image (typically the raw) is called after it's SHA1, e.g.
c5da46c6497eebe7634a6a02279490e9bbcb5efe.raw
images derived from it (e.g. JPEGs) have some string attached
c5da46c6497eebe7634a6a02279490e9bbcb5efe-foobarWhatever.jpeg

Now two problems come up.
1) Obviously we can't write "foo" in the regexps to mark the characters that
should be identical on all grouped images.
I would probably solve this by adding a field, which of the subpatterns (i.e.
the stuff in "(...)" ) needs to be identical.
This way one could e.g. write:
"^(.*)\.(jpeg|jpg|raw)$";1
To tell, for a file to be grouped, subpattern 1 must be identical and apart
from that any file ending with a dot . and jpeg, jpg or raw.
Or my example above with the hashsums:
"^(.*)(-.+|)\.(jpeg|jpg)$";1
To tell, for a file to be grouped, subpattern 1 must be identical, and either
followed by a dash - and one or more arbitrary characters (or by nothing)...
and then followed by a dot . and followed by some extensions.


2) There need to be a way to select the "primary" image, i.e. those which is
opened to be viewed, or from which tumbnails are created, etc.
Either one could do this by another regexp and/or by file flags like "most
recently created/modified".


Of course all that would be quite a complex system, on the other hand I think
it would be worth it, as it allows for very mighty grouping mechanisms to be
used.


Cheers,
Chris.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping

Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

--- Comment #1 from Christoph Anton Mitterer <[hidden email]> ---
One way for having such stuff per directory would be to add .digikam files with
such configurations in such directories :)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from [hidden email] ---
We just finished implementing a somewhat similar feature called "Group Selected
Images By Regex" - see the following post:

https://plus.google.com/107260423308980038020/posts/2RNd1c9YksN

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

--- Comment #3 from [hidden email] ---
Created attachment 84861
  --> https://bugs.kde.org/attachment.cgi?id=84861&action=edit
Implement "group by regex" menu item and configuration dialogue

Boost-regex is used in favour of Qregex since Boost features real PCRE syntax
(including greedy/non-greedy selection that doesn't need to be hardcoded into
the application).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

--- Comment #4 from [hidden email] ---
Created attachment 84862
  --> https://bugs.kde.org/attachment.cgi?id=84862&action=edit
Screenshot of the "group by regex" context menu item

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

--- Comment #5 from [hidden email] ---
Created attachment 84863
  --> https://bugs.kde.org/attachment.cgi?id=84863&action=edit
Screenshot of the "group by regex" configuration dialogue

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping

Christoph Anton Mitterer
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

--- Comment #6 from Christoph Anton Mitterer <[hidden email]> ---
Hey.

I think you really should consider to make this per-directory configurable...
like I proposed by storing it in a .digikam file or so,... or perhaps also via
XATTRs (XATTRs alone are not enough, since these are not usable in all cases).
And one should probably make such setting _optionally_ inheritable to
subdirectories (unless another .digikam file overrides again.

Also, I think (2) form above is not possible right now, right?

Cheers,
Chris.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping [patch]

Gilles Caulier-4
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|regexp based image grouping |regexp based image grouping
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping [patch]

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84861|0                           |1
        is obsolete|                            |

--- Comment #7 from [hidden email] ---
Created attachment 85200
  --> https://bugs.kde.org/attachment.cgi?id=85200&action=edit
Implement "group by regex" menu item and configuration dialogue

remerged patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping [patch]

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85200|0                           |1
        is obsolete|                            |

--- Comment #8 from [hidden email] ---
Created attachment 86614
  --> https://bugs.kde.org/attachment.cgi?id=86614&action=edit
remerged patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] regexp based image grouping [patch]

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86614|remerged patch              |Implement "group by regex"
        description|                            |menu item and configuration
                   |                            |dialogue Boost-regex is
                   |                            |used in favour of Qregex
                   |                            |since Boost features real
                   |                            |PCRE syntax (including
                   |                            |greedy/non-greedy selection
                   |                            |that doesn't need to be
                   |                            |hardcoded into the
                   |                            |application).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

Gilles Caulier-4
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|regexp based image grouping |GROUP : regexp based image
                   |[patch]                     |grouping [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

Jasper
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

Jasper <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Jasper <[hidden email]> ---
The patch cannot work against dk git as albumsettings.cpp does not exist (for
example). Any chance of an updated patch, or better, inclusion in digikam?
Cheers

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86614|0                           |1
        is obsolete|                            |

--- Comment #10 from [hidden email] ---
Created attachment 89119
  --> https://bugs.kde.org/attachment.cgi?id=89119&action=edit
remerged patch against 4.5

Implement "group by regex" menu item and configuration dialogue Boost-regex is
used in favour of Qregex since Boost features real PCRE syntax (including
greedy/non-greedy selection that doesn't need to be hardcoded into the
application).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

Jasper
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

--- Comment #11 from Jasper <[hidden email]> ---
Thanks for the patch.
 I am a regex NooB, so not sure if the failure to group images is due to my
lack of understanding, or digikam being buggy atm (<1 min unresponsive..).
 I tried:
^.\..$
to group jpg and raw together.  But no change 8(
 My asumption was that having selected a whole bunch of images the jpg's and
the cr2's would be grouped.

Trying to understand how the above regex creates the group with
http://regex101.com/r/gT3vD6/1  but failing 8)

Also tried one from the history... no change (not suprised there 8)

This is an essential feature IMHO if _only_ to group jpg and raw, not to
mention what else you must be able to do! What do we need to do to help support
this becoming part of mainline as a user?
Cheers

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84863|0                           |1
        is obsolete|                            |

--- Comment #12 from [hidden email] ---
Created attachment 90528
  --> https://bugs.kde.org/attachment.cgi?id=90528&action=edit
Screenshot of the "group by filename" configuration dialogue

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84862|0                           |1
        is obsolete|                            |

--- Comment #13 from [hidden email] ---
Created attachment 90529
  --> https://bugs.kde.org/attachment.cgi?id=90529&action=edit
Screenshot of the "group by filename" context menu item

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
kde
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

kde
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89119|0                           |1
        is obsolete|                            |

--- Comment #14 from [hidden email] ---
Created attachment 90531
  --> https://bugs.kde.org/attachment.cgi?id=90531&action=edit
remerged "group by filename" patch against 4.7

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

Gilles Caulier-4
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

--- Comment #15 from Gilles Caulier <[hidden email]> ---
As i don't recieve a reponse from your post on mailing list, i CC my message in
this file :

As i already said, I'm not favorable to include Regular Expression
rules in digiKam GUI. It's not users friendly. Using RegEx in source code is
not a problem of course.

For the rest of features, there is no problem...

digiKam for KDE4 is frozen for new features (git/master). Only bugfixes will be
introduced in this code. This want mean that patch must be adapted to
"frameworks" git branch, where new features are introduced. Details about
digiKam for KF5 can be found here :

https://techbase.kde.org/Projects/Digikam/CodingSprint2014

- Patch must be ported to pure Qt5. You must drop KDE API use in your patch.
The
plan is to limit KDE dependencies in digiKam later, in goal to make it more
portable in the future.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[digikam] [Bug 318357] GROUP : regexp based image grouping [patch]

Christoph Anton Mitterer
In reply to this post by Christoph Anton Mitterer
https://bugs.kde.org/show_bug.cgi?id=318357

--- Comment #16 from Christoph Anton Mitterer <[hidden email]> ---
(In reply to Gilles Caulier from comment #15)
> As i don't recieve a reponse from your post on mailing list, i CC my message
> in this file :
Whom do you mean?

> As i already said, I'm not favorable to include Regular Expression
> rules in digiKam GUI. It's not users friendly.
I don't really see any problem... one can either disable the feature per
default or provide a default which will work for many users (e.g. to group same
name with different .ext).

Since digikam strives to be a professional photo management/collection
software, I think a feature like the regexp-based grouping is really important
(since all pros have their pics usually in different "versions".

> Using RegEx in source code is
> not a problem of course.
Which makes the whole thing basically uninteresting, when it's a) just a patch
never merged (and thus never gets into distros) or b) there is just one set of
rules (which like doesn't fit what one wants.


Cheers,
Chris.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12
Loading...